fix warp assert on pow of 2#382
Open
39ali wants to merge 2 commits intoRust-GPU:mainfrom
Open
Conversation
fee1-dead
reviewed
Apr 30, 2026
|
|
||
| assert!( | ||
| !(width & (width - 1)) != 0 && width <= 32, | ||
| width != 0 && (width & (width - 1)) == 0 && width <= 32, |
Contributor
There was a problem hiding this comment.
Why can't we use https://doc.rust-lang.org/std/primitive.u32.html#method.is_power_of_two here?
Author
There was a problem hiding this comment.
that's true, we should use it, changing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rust
!on integers isbitwise NOT,not logical NOT, now it should assert correctly on none pow of 2cargo buildpassescargo clippy --workspacepassesNotes
Any additional context for reviewers.